14 replies to this topic

[gameboy]

Press the Delete button:
Delete the old archive, an error occurs:

<p class="error">ERROR: JavaScript error: gui/savedgames/load.js line 72
TypeError: Engine.DeleteSavedGame is not a function
reallyDeleteGame("quicksave-0029")@gui/savedgames/load.js:72
()@gui/savedgames/load.js:66
([object Object])@Some XML file:55</p>
<p class="error">ERROR: JavaScript error: gui/savedgames/load.js line 72
TypeError: Engine.DeleteSavedGame is not a function
reallyDeleteGame("quicksave-0028")@gui/savedgames/load.js:72
()@gui/savedgames/load.js:66

Edited by gameboy, 04 March 2012 - 09:07 AM.

[historic_bruno]

That changes requires a rebuild (or you can use the autobuild).

[gameboy]

But the error persists, you can test it, thank you!

[quantumstate]

gameboy, on 08 March 2012 - 12:18 PM, said:

But the error persists, you can test it, thank you!

I can't reproduce the error. I just successfully deleted several old saved games. Can you give more details about which version of the game and OS you are using? Also is the error message exactly the same as before?

[gameboy]

ok, My operating system is: win7 32bit.
I tested version of the game: the ALPHA VIII (svn-11285)

[historic_bruno]

That image is too low quality to see the error. Can you paste the error from the log? (interestinglog.html)

[gameboy]

0 A.D. Main log (warnings and errors only)
ERROR: JavaScript error: gui/savedgames/load.js line 72 TypeError: Engine.DeleteSavedGame is not a function reallyDeleteGame("quicksave-0039")@gui/savedgames/load.js:72 ()@gui/savedgames/load.js:66 ([object Object])@Some XML file:55

ERROR: JavaScript error: gui/savedgames/load.js line 72 TypeError: Engine.DeleteSavedGame is not a function reallyDeleteGame("quicksave-0040")@gui/savedgames/load.js:72 ()@gui/savedgames/load.js:66 ([object Object])@Some XML file:55

[quantumstate]

This is a strange error. Is the svn checkout completing correctly? Also are you compiling yourself or using the autobuild?

[gameboy]

yes,Checked out from SVN. I am using the autobuild. thank you!

[gudo]

Hmmmm... I've attempted to duplicate this bug, and while I couldn't get it to work as advertised, I did discover a few new ones.

1)Save several games, quit to menu, open the Load Game menu
2)In your file manager (as in, NOT in game) locate the save files.
3)Delete said saves using your file manager.
4)In game, attempt to delete the any saved game OTHER THAN the first one on the list

Game should crash to desktop with the following error. When I attempted to delete the first game on the list, it mearly warned that the file could not be read, and refreshed the list of saved games.

Spoiler

Function call failed: return value was -1 (Function failed (no details available))
Location: SavedGame.cpp:152 (SavedGames::Load)

Call stack:

(error while dumping stack: No stack frames found)
errno = 2 (No such file or directory)
OS error = 2 (The system cannot find the file specified.)

It also happened (produced the same error too) when you do the above steps, but instead of deleting an already deleted game, you try and load it up.

I used to most recent SVN autobuild. Win 7, on the off chance that makes a difference.

Edited by gudo, 13 March 2012 - 02:38 AM.

[gameboy]

This issue is resolved, thank you!

[historic_bruno]

gudo, on 13 March 2012 - 02:37 AM, said:

1)Save several games, quit to menu, open the Load Game menu
2)In your file manager (as in, NOT in game) locate the save files.
3)Delete said saves using your file manager.
4)In game, attempt to delete the any saved game OTHER THAN the first one on the list

Found this error, it will be fixed soon (it's a different error than the one below)

Quote

Game should crash to desktop with the following error. When I attempted to delete the first game on the list, it mearly warned that the file could not be read, and refreshed the list of saved games.

Spoiler

Function call failed: return value was -1 (Function failed (no details available))
Location: SavedGame.cpp:152 (SavedGames::Load)

Call stack:

(error while dumping stack: No stack frames found)
errno = 2 (No such file or directory)
OS error = 2 (The system cannot find the file specified.)

It also happened (produced the same error too) when you do the above steps, but instead of deleting an already deleted game, you try and load it up.

This one's a bit more troubling, but I'll see if I can fix it

[gudo]

One of us is a bit confused 1-4 is the steps to replicate the bug, the following paragraph is what happened.

[historic_bruno]

Thanks for reporting the errors with steps to reproduce, very helpful Those crashes should be fixed in r11332 (or wait for an autobuild).

[gudo]

Nice! Everything looks fixed to me.